Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Pool section disappearing after selecting rendering OS and switching back to normal #1584

Merged
merged 6 commits into from
Sep 5, 2018

Conversation

timotheeguerin
Copy link
Member

@timotheeguerin timotheeguerin commented Sep 4, 2018

Fix #1576

Issue was with form section being added when picking rendering os(License picker section) and angular not registering the changes correctly when removing it

@codecov
Copy link

codecov bot commented Sep 4, 2018

Codecov Report

Merging #1584 into master will decrease coverage by <.01%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1584      +/-   ##
==========================================
- Coverage   62.42%   62.42%   -0.01%     
==========================================
  Files        1112     1112              
  Lines       25603    25602       -1     
  Branches     4119     4117       -2     
==========================================
- Hits        15983    15981       -2     
- Misses       9620     9621       +1
Impacted Files Coverage Δ
...ount/browse/account-list/account-list.component.ts 82.69% <100%> (-1.24%) ⬇️
...l/action/add/pool-create-basic-dialog.component.ts 19.09% <100%> (-0.73%) ⬇️
...ask/ui/form/form-section/form-section.component.ts 100% <100%> (ø) ⬆️
...tch-flask/ui/form/form-page/form-page.component.ts 88% <87.5%> (-2.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3172b6...37feb0d. Read the comment docs.

@timotheeguerin timotheeguerin merged commit b0901fa into master Sep 5, 2018
@timotheeguerin timotheeguerin deleted the fix/pool-form-disapearing branch September 5, 2018 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant