Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix task clone user identity #1617

Merged
merged 2 commits into from
Sep 20, 2018
Merged

Conversation

timotheeguerin
Copy link
Member

@timotheeguerin timotheeguerin commented Sep 20, 2018

fix #1616

Todo:

  • tests

@codecov
Copy link

codecov bot commented Sep 20, 2018

Codecov Report

Merging #1617 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1617      +/-   ##
==========================================
+ Coverage   62.33%   62.34%   +0.01%     
==========================================
  Files        1209     1211       +2     
  Lines       28655    28664       +9     
  Branches     4425     4426       +1     
==========================================
+ Hits        17861    17870       +9     
  Misses      10762    10762              
  Partials       32       32
Impacted Files Coverage Δ
app/models/dtos/task-create/index.ts 100% <100%> (ø)
app/models/dtos/user-identity.dto.ts 100% <100%> (ø)
app/models/user-account.ts 87.5% <100%> (ø) ⬆️
app/models/dtos/index.ts 100% <100%> (ø) ⬆️
app/models/dtos/task-create/task-create.dto.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3b258e...e249032. Read the comment docs.

@timotheeguerin timotheeguerin merged commit d635d92 into master Sep 20, 2018
@timotheeguerin timotheeguerin deleted the fix/task-clone-user-identity branch September 20, 2018 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cloning tasks having issue with user identity
1 participant