Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add container length validation #1662

Merged
merged 3 commits into from
Oct 2, 2018

Conversation

timotheeguerin
Copy link
Member

fix #1641

@codecov
Copy link

codecov bot commented Oct 1, 2018

Codecov Report

Merging #1662 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1662   +/-   ##
=======================================
  Coverage   63.46%   63.46%           
=======================================
  Files        1238     1238           
  Lines       29166    29166           
  Branches     4524     4524           
=======================================
  Hits        18511    18511           
  Misses      10624    10624           
  Partials       31       31
Impacted Files Coverage Δ
src/common/constants/constants.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5bb36d...0769910. Read the comment docs.

@timotheeguerin timotheeguerin merged commit 04047fd into master Oct 2, 2018
@timotheeguerin timotheeguerin deleted the feature/add-container-length-validation branch October 2, 2018 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add validation on container length(Between 3 and 63 characters)
1 participant