Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Create pool with custom image broken #1678

Merged
merged 3 commits into from
Oct 4, 2018
Merged

Conversation

timotheeguerin
Copy link
Member

fix #1677

@codecov
Copy link

codecov bot commented Oct 4, 2018

Codecov Report

Merging #1678 into stable will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           stable    #1678      +/-   ##
==========================================
+ Coverage   63.39%   63.39%   +<.01%     
==========================================
  Files        1237     1237              
  Lines       29106    29107       +1     
  Branches     4519     4519              
==========================================
+ Hits        18452    18453       +1     
  Misses      10623    10623              
  Partials       31       31
Impacted Files Coverage Δ
app/models/forms/create-pool-model.ts 17.5% <ø> (ø) ⬆️
...p/models/dtos/virtual-machine-configuration.dto.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbed697...2489628. Read the comment docs.

@timotheeguerin timotheeguerin merged commit 71f2bfd into stable Oct 4, 2018
@timotheeguerin timotheeguerin deleted the fix/custom-image branch October 4, 2018 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants