Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal: Handle release retries by not re-uploading artifact #1694

Merged
merged 6 commits into from
Oct 9, 2018

Conversation

timotheeguerin
Copy link
Member

@timotheeguerin timotheeguerin commented Oct 9, 2018

fix #1689
This will try the following:

  • Upload the file to blob
  • If it fails because blob already exists compare the md5 of the blob with the local file
  • If this is the same just pass as the file is already up to date on the blob
  • If the file is different throw an error and fail the release(File shouldn't be there or release has wrong version)

@codecov
Copy link

codecov bot commented Oct 9, 2018

Codecov Report

Merging #1694 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1694   +/-   ##
=======================================
  Coverage   57.11%   57.11%           
=======================================
  Files         923      923           
  Lines       24920    24920           
  Branches     4529     4529           
=======================================
  Hits        14232    14232           
  Misses      10657    10657           
  Partials       31       31

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eef0b0d...2d37c42. Read the comment docs.

@timotheeguerin timotheeguerin merged commit 479383a into master Oct 9, 2018
@timotheeguerin timotheeguerin deleted the internal/better-release branch October 9, 2018 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release step make resilient to storage error
1 participant