Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Local template library #1697

Merged
merged 30 commits into from
Oct 19, 2018
Merged

Conversation

timotheeguerin
Copy link
Member

@timotheeguerin timotheeguerin commented Oct 9, 2018

fix #1696
Current UI(WIP)

image

Todo:

  • Custom template viewer(Right now read only)
  • Submit template
  • Drag and drop to have a one time run
  • Tests

@codecov
Copy link

codecov bot commented Oct 15, 2018

Codecov Report

Merging #1697 into master will increase coverage by 0.05%.
The diff coverage is 64.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1697      +/-   ##
==========================================
+ Coverage   57.85%   57.91%   +0.05%     
==========================================
  Files         929      930       +1     
  Lines       25042    25082      +40     
  Branches     4553     4555       +2     
==========================================
+ Hits        14487    14525      +38     
- Misses      10524    10526       +2     
  Partials       31       31
Impacted Files Coverage Δ
app/services/ncj-template.service.ts 8.95% <ø> (+1.26%) ⬆️
src/common/constants/constants.ts 100% <ø> (ø) ⬆️
...ask/ui/file/file-viewer/file-viewer/file-viewer.ts 100% <ø> (ø) ⬆️
src/@batch-flask/ui/electron/fs.service.ts 14.28% <0%> (-2.39%) ⬇️
src/client/core/fs.ts 14.7% <0%> (-1.17%) ⬇️
...-type-association/file-type-association.service.ts 95.23% <100%> (+2.13%) ⬆️
...ch-flask/ui/file/file-navigator/file-tree.model.ts 84.53% <100%> (+0.66%) ⬆️
app/models/ncj-job-template.ts 100% <100%> (ø) ⬆️
app/services/ncj/ncj.module.ts 100% <100%> (ø)
...nts/market/submit/submit-ncj-template.component.ts 58.06% <11.53%> (-3.44%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3d7d06...74d4284. Read the comment docs.

@timotheeguerin timotheeguerin merged commit 9321334 into master Oct 19, 2018
@timotheeguerin timotheeguerin deleted the feature/local-template-folder branch October 19, 2018 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local template library
1 participant