Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: VM Sizes picker show basic input when unable to get vm sizes(Local account) #1811

Merged
merged 9 commits into from
Dec 3, 2018

Conversation

timotheeguerin
Copy link
Member

fix #1810

@codecov
Copy link

codecov bot commented Dec 3, 2018

Codecov Report

Merging #1811 into master will increase coverage by 0.17%.
The diff coverage is 94.02%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1811      +/-   ##
==========================================
+ Coverage   60.04%   60.22%   +0.17%     
==========================================
  Files         958      958              
  Lines       26099    26063      -36     
  Branches     4736     4732       -4     
==========================================
+ Hits        15672    15696      +24     
+ Misses      10393    10333      -60     
  Partials       34       34
Impacted Files Coverage Δ
src/app/services/pricing.service.ts 8% <ø> (ø) ⬆️
src/app/services/quota.service.ts 9.72% <ø> (ø) ⬆️
...rc/app/services/github-data/github-data.service.ts 100% <100%> (+18.18%) ⬆️
...ion/add/vm-size-picker/vm-size-picker.component.ts 88.18% <100%> (+1.31%) ⬆️
src/app/services/compute/vm-size.service.ts 85.71% <85.71%> (ø)
src/app/services/compute.service.ts 23.07% <0%> (+5.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecb91ab...323125e. Read the comment docs.

@timotheeguerin timotheeguerin merged commit ce53342 into master Dec 3, 2018
@timotheeguerin timotheeguerin deleted the feature/vm-size-alt branch December 3, 2018 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VM size picker alternative if can't load the vm sizes(Local account)
1 participant