Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal: Unify file system interfaces and replace mkdirp to make-dir #1867

Merged
merged 9 commits into from
Jan 16, 2019

Conversation

timotheeguerin
Copy link
Member

@timotheeguerin timotheeguerin commented Jan 15, 2019

fix #1866

Only one class that can be imported in browser and in main process

mkdirp has a few issue and doesn't seem maintained anymore

@timotheeguerin timotheeguerin changed the title Internal: Unify file system interfaces Internal: Unify file system interfaces and replace mkdirp to make-dir Jan 15, 2019
@codecov
Copy link

codecov bot commented Jan 15, 2019

Codecov Report

Merging #1867 into master will decrease coverage by <.01%.
The diff coverage is 40.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1867      +/-   ##
==========================================
- Coverage   61.88%   61.87%   -0.01%     
==========================================
  Files         991      986       -5     
  Lines       26887    26865      -22     
  Branches     4938     4938              
==========================================
- Hits        16639    16623      -16     
+ Misses      10211    10205       -6     
  Partials       37       37
Impacted Files Coverage Δ
src/@batch-flask/ui/batchui.module.ts 100% <ø> (ø) ⬆️
src/app/components/task/action/task-commands.ts 17.94% <ø> (ø) ⬆️
...ctory-picker/file-or-directory-picker.component.ts 66.66% <ø> (ø) ⬆️
src/app/services/themes/theme.service.ts 8.53% <ø> (ø) ⬆️
.../services/telemetry/renderer-telemetry-uploader.ts 80.95% <ø> (ø) ⬆️
src/@batch-flask/ui/file/cloud-file.service.ts 13.79% <ø> (ø) ⬆️
.../app/services/node-connect/node-connect.service.ts 87.09% <ø> (ø) ⬆️
src/app/components/pool/action/pool-commands.ts 13.84% <ø> (ø) ⬆️
src/@batch-flask/electron/os.service.ts 27.27% <ø> (ø)
src/app/services/adal/adal.service.ts 93.87% <ø> (ø) ⬆️
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c406564...8da9c8e. Read the comment docs.

@timotheeguerin timotheeguerin merged commit 5d341dc into master Jan 16, 2019
@timotheeguerin timotheeguerin deleted the fix/fs-single branch January 16, 2019 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify filesystem interfaces
1 participant