Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Sub tasks show relevant tasks settings & cleanup #1900

Merged
merged 10 commits into from
Feb 5, 2019

Conversation

timotheeguerin
Copy link
Member

@timotheeguerin timotheeguerin commented Feb 5, 2019

fix #1554
Show coordination command line, number of instances

image

@timotheeguerin timotheeguerin changed the title Feature: Sub tasks show relevant tasks settings Feature: Sub tasks show relevant tasks settings & cleanup Feb 5, 2019
@codecov
Copy link

codecov bot commented Feb 5, 2019

Codecov Report

Merging #1900 into master will increase coverage by 0.03%.
The diff coverage is 72.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1900      +/-   ##
==========================================
+ Coverage   64.12%   64.15%   +0.03%     
==========================================
  Files        1006     1006              
  Lines       27582    27566      -16     
  Branches     5043     5039       -4     
==========================================
- Hits        17687    17686       -1     
+ Misses       9857     9842      -15     
  Partials       38       38
Impacted Files Coverage Δ
src/app/models/subtask-information.ts 100% <ø> (ø) ⬆️
src/app/models/azure-batch/task/task.ts 94.44% <ø> (ø) ⬆️
...app/components/task/details/task-details.module.ts 100% <ø> (ø) ⬆️
.../details/sub-tasks/list/sub-task-list.component.ts 35.71% <100%> (ø)
...-tasks/properties/sub-task-properties.component.ts 100% <100%> (ø)
...k/details/sub-tasks/sub-tasks-browser.component.ts 17.24% <57.14%> (ø)
src/@batch-flask/electron/clipboard.service.ts 50% <0%> (+25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10c5a08...d5c6483. Read the comment docs.

@timotheeguerin timotheeguerin merged commit c1cd42f into master Feb 5, 2019
@timotheeguerin timotheeguerin deleted the tweaks/sub-tasks branch February 5, 2019 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display multi instance settings on the sub task
1 participant