Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Simplification of the node connect experience #1992

Merged
merged 19 commits into from
Mar 27, 2019

Conversation

timotheeguerin
Copy link
Member

@timotheeguerin timotheeguerin commented Mar 22, 2019

fix #1991
image

With password
image

@codecov
Copy link

codecov bot commented Mar 25, 2019

Codecov Report

Merging #1992 into master will increase coverage by 0.02%.
The diff coverage is 80.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1992      +/-   ##
==========================================
+ Coverage   65.29%   65.31%   +0.02%     
==========================================
  Files        1028     1028              
  Lines       28164    28151      -13     
  Branches     5025     5028       +3     
==========================================
- Hits        18390    18388       -2     
+ Misses       9758     9747      -11     
  Partials       16       16
Impacted Files Coverage Δ
...tch-flask/ui/property-list/property-list.module.ts 100% <ø> (ø) ⬆️
...app/components/node/connect/node-connect.module.ts 100% <ø> (ø) ⬆️
src/common/constants/constants.ts 100% <ø> (ø) ⬆️
src/app/services/ssh-key.service.ts 14.28% <0%> (-0.72%) ⬇️
...connect/ssh-key-picker/ssh-key-picker.component.ts 88% <100%> (+3.38%) ⬆️
...sk/ui/duration-picker/duration-picker.component.ts 90.57% <100%> (+0.06%) ⬆️
...y-picker-dialog/ssh-key-picker-dialog.component.ts 60% <60%> (ø)
...roperty-display/node-property-display.component.ts 71.11% <70%> (+5.77%) ⬆️
.../components/node/connect/node-connect.component.ts 90.9% <86.76%> (+9.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d98556f...fbf1dba. Read the comment docs.

@timotheeguerin timotheeguerin merged commit a734e86 into master Mar 27, 2019
@timotheeguerin timotheeguerin deleted the feature/node-connect-simplify branch March 27, 2019 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node connect experience merge configure page
1 participant