Dynamically adjust recent template text based on window size #2011
Conversation
| })); | ||
| } | ||
|
|
||
| @HostListener("window:resize", ["$event"]) |
There was a problem hiding this comment.
you should be able to do all of that just with css. This looks a bit too complex for what it should be
There was a problem hiding this comment.
The issue with CSS is that it trims the end of the string, we want the start of the string to be trimmed so we can still see the template name, if we can do this with CSS then go for it. Just not sure it's doable.
There was a problem hiding this comment.
First yes it is possible to ellipsis at the beginning, we talked with zhiqiang the issue here is the title is not just the filename it contains the entire title shown on the submit form Run template foo.ts. Adding ... in the middle depending on what the text start with is quite hacky and will break at some point(Localization for example) For now we'll just make sure the button doesn't show up alone on the new line. Then we can think of a way to change so that only the path(Or action name) is passed to the recent template so that can be stripped
Codecov Report
@@ Coverage Diff @@
## stable #2011 +/- ##
======================================
Coverage 65% 65%
======================================
Files 1014 1014
Lines 27718 27718
Branches 4941 4941
======================================
Hits 18018 18018
Misses 9684 9684
Partials 16 16Continue to review full report at Codecov.
|
fix #1969 Dynamically adjust recent template text based on window size