Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug where required caused save to be disabled even though populated #2091

Merged
merged 4 commits into from
Oct 9, 2019
Merged

Fix bug where required caused save to be disabled even though populated #2091

merged 4 commits into from
Oct 9, 2019

Conversation

bgklein
Copy link
Contributor

@bgklein bgklein commented Sep 27, 2019 •
edited by cRui861
Loading

Fix #2103

@bgklein bgklein changed the title Fix bug where required caused save to be grayed out Fix bug where required caused save to be disabled even though populated Sep 27, 2019
@codecov
Copy link

codecov bot commented Sep 27, 2019 •
edited
Loading

Codecov Report

Merging #2091 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2091      +/-   ##
==========================================
+ Coverage   65.02%   65.02%   +<.01%     
==========================================
  Files         896      896              
  Lines       25629    25635       +6     
  Branches     5054     5056       +2     
==========================================
+ Hits        16664    16670       +6     
  Misses       8965     8965
Impacted Files Coverage Δ
src/app/utils/component-utils/component-utils.ts 89.47% <ø> (ø) ⬆️
...sk/ui/duration-picker/duration-picker.component.ts 90.78% <100%> (+0.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53d5442...fb73c96. Read the comment docs.

@timotheeguerin
Copy link
Member

Kinda confused by what you changed now

@bgklein bgklein merged commit ac1c83f into master Oct 9, 2019
@cRui861 cRui861 added this to the 2.4.0 milestone Oct 23, 2019
@cRui861 cRui861 added 🐛 bug and removed 🐛 bug labels Oct 24, 2019
@cRui861 cRui861 removed this from the 2.4.0 milestone Oct 24, 2019
@cRui861 cRui861 mentioned this pull request Oct 24, 2019
Closed
@cRui861 cRui861 deleted the remove-required branch February 1, 2022 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timotheeguerin timotheeguerin timotheeguerin left review comments

@cRui861 cRui861 cRui861 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Required caused save to be disabled even though populated
3 participants
@bgklein @timotheeguerin @cRui861