Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pool Resize Error Default #2121

Merged
merged 3 commits into from
Nov 8, 2019
Merged

Pool Resize Error Default #2121

merged 3 commits into from
Nov 8, 2019

Conversation

cRui861
Copy link
Member

@cRui861 cRui861 commented Nov 7, 2019

Changed the error message details to display by default.

@codecov
Copy link

codecov bot commented Nov 7, 2019

Codecov Report

Merging #2121 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2121   +/-   ##
=======================================
  Coverage   65.13%   65.13%           
=======================================
  Files         898      898           
  Lines       25694    25694           
  Branches     5065     5065           
=======================================
  Hits        16735    16735           
  Misses       8959     8959
Impacted Files Coverage Δ
src/@batch-flask/ui/banner/banner.component.ts 82.6% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ee5f8a...27423ed. Read the comment docs.

Copy link
Contributor

@bgklein bgklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sent a PR to this branch though to fix a banner.

@cRui861 cRui861 merged commit 308404d into master Nov 8, 2019
@cRui861 cRui861 deleted the err-default branch November 8, 2019 01:15
@bgklein
Copy link
Contributor

bgklein commented Dec 12, 2019

#2140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants