Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autodesk Arnold Meter Change #2178

Merged
merged 8 commits into from
May 20, 2020
Merged

Autodesk Arnold Meter Change #2178

merged 8 commits into from
May 20, 2020

Conversation

cRui861
Copy link
Member

@cRui861 cRui861 commented May 8, 2020

Updated Autodesk Arnold meter pricing and units, and added Chaos Group V-Ray RT to list of available software.

  • EULA for V-Ray RT is the same as EULA for V-Ray

Current list of software available:
image

Chaos Group V-Ray RT EULA link:
image

@cRui861 cRui861 requested a review from bgklein May 8, 2020 23:40
@codecov
Copy link

codecov bot commented May 8, 2020

Codecov Report

Merging #2178 into master will increase coverage by 0.00%.
The diff coverage is 61.53%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2178   +/-   ##
=======================================
  Coverage   65.13%   65.13%           
=======================================
  Files         898      899    +1     
  Lines       25713    25718    +5     
  Branches     5077     5077           
=======================================
+ Hits        16747    16751    +4     
- Misses       8966     8967    +1     
Impacted Files Coverage Δ
...cense-eula-dialog/license-eula-dialog.component.ts 25.00% <0.00%> (-2.28%) ⬇️
src/app/services/pricing.service.ts 8.16% <0.00%> (ø)
...app-license-picker/app-license-picker.component.ts 96.49% <100.00%> (-0.07%) ⬇️
src/app/models/batch-software-license.ts 100.00% <100.00%> (ø)
src/app/models/software-billing-unit.ts 100.00% <100.00%> (ø)
src/app/services/pricing/pricing.model.ts 19.78% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acc2007...ad3a174. Read the comment docs.

@cRui861 cRui861 requested review from dpwatrous and gingi May 12, 2020 00:03
@cRui861 cRui861 marked this pull request as ready for review May 12, 2020 00:03
Copy link
Member

@dpwatrous dpwatrous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall - I'd just switch string to SoftwareBillingUnit on PricingService.

@cRui861 cRui861 merged commit 09007ae into master May 20, 2020
@cRui861 cRui861 deleted the rechen/arnold-meter-change branch May 20, 2020 18:12
@cRui861
Copy link
Member Author

cRui861 commented Jan 15, 2021

Fixed #2242

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants