Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the default Electron User-Agent string #2216

Merged
merged 1 commit into from
Sep 10, 2020

Conversation

dpwatrous
Copy link
Member

@dpwatrous dpwatrous commented Sep 10, 2020

Fixes #2212 and Fixes #2165

The User-Agent string being sent was exposing a bug in AAD auth when setting up 2-factor verification. Including the default Electron User-Agent string fixed this issue.

@codecov
Copy link

codecov bot commented Sep 10, 2020

Codecov Report

Merging #2216 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2216   +/-   ##
=======================================
  Coverage   65.13%   65.14%           
=======================================
  Files         899      899           
  Lines       25654    25660    +6     
  Branches     5091     5092    +1     
=======================================
+ Hits        16710    16715    +5     
- Misses       8944     8945    +1     
Impacted Files Coverage Δ
...-tasks/properties/sub-task-properties.component.ts 88.88% <0.00%> (-11.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72cad52...f66ded7. Read the comment docs.

@bgklein
Copy link
Contributor

bgklein commented Sep 10, 2020

Also Fixes #2165

@dpwatrous
Copy link
Member Author

Good catch - I totally missed that this was basically the fix you had for Okta!

@dpwatrous dpwatrous merged commit b5de3c4 into master Sep 10, 2020
@dpwatrous dpwatrous deleted the dpwatrous/electron-user-agent branch September 10, 2020 19:32
@cRui861 cRui861 modified the milestone: 2.8.0 Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Impossible to verify account and complete login BatchExplorer does not work with Okta
3 participants