Fixes TypeScript in upload-to-storage #2289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gingi
requested review from
cRui861,
dpwatrous,
paterasMSFT and
zfengms
as code owners
Codecov Report
@@ Coverage Diff @@
## master #2289 +/- ##
=======================================
Coverage 65.19% 65.19%
=======================================
Files 903 903
Lines 25712 25712
Branches 5105 5105
=======================================
Hits 16763 16763
Misses 8949 8949 Continue to review full report at Codecov.
|
Used in the release pipeline.
gingi
force-pushed
the
bugfix/storage-upload-script
branch
from
57d5f66 to
ff1212b
Compare
cRui861
approved these changes
Feb 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used in the release pipeline.
Had not realized that the JS version of the file is being used in the release pipeline, and conversion to TS missed several imports and type definitions.