Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multiple accessibility issues #2575

Merged
merged 6 commits into from
Oct 10, 2022
Merged

fix: multiple accessibility issues #2575

merged 6 commits into from
Oct 10, 2022

Conversation

wanghoppe
Copy link
Member

@wanghoppe wanghoppe commented Sep 28, 2022

@ghost
Copy link

ghost commented Sep 28, 2022

CLA assistant check
All CLA requirements met.

@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Merging #2575 (b10a394) into master (3fecbf5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2575   +/-   ##
=======================================
  Coverage   65.00%   65.00%           
=======================================
  Files         915      915           
  Lines       26366    26366           
  Branches     5190     5190           
=======================================
  Hits        17138    17138           
  Misses       9228     9228           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fecbf5...b10a394. Read the comment docs.

Copy link
Member

@dpwatrous dpwatrous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall - just a couple comments.

@wanghoppe wanghoppe enabled auto-merge October 8, 2022 03:08
@dpwatrous dpwatrous self-requested a review October 10, 2022 13:01
@wanghoppe wanghoppe merged commit edeb2ba into master Oct 10, 2022
@wanghoppe wanghoppe deleted the hoppe/accessibility branch October 10, 2022 13:02
@cRui861
Copy link
Member

cRui861 commented Feb 1, 2023

Fixes #2634

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants