Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to new Azure Storage SDK #2580

Merged
merged 3 commits into from
Jan 11, 2023
Merged

Conversation

gingi
Copy link
Member

@gingi gingi commented Oct 18, 2022

Migrates from azure-storage 2.10.7 to @azure/storage-blob 12.11.0.

Other minor changes:

  • Fixes poll rate for refresh by EntityView
  • Improves the storage container delete dialog

image image

@gingi gingi force-pushed the feature/upgrade-azure-storage branch 2 times, most recently from f15b528 to c76e6e0 Compare November 29, 2022 23:07
@gingi gingi marked this pull request as ready for review November 29, 2022 23:07
@gingi gingi force-pushed the feature/upgrade-azure-storage branch 2 times, most recently from c69f049 to 6f1d2d6 Compare November 30, 2022 18:51
@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Merging #2580 (6880c25) into master (19ae786) will increase coverage by 0.34%.
The diff coverage is 17.85%.

❗ Current head 6880c25 differs from pull request most recent head 0d6b28f. Consider uploading reports for the commit 0d6b28f to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2580      +/-   ##
==========================================
+ Coverage   64.87%   65.22%   +0.34%     
==========================================
  Files         916      916              
  Lines       26493    26350     -143     
  Branches     5227     5194      -33     
==========================================
- Hits        17188    17187       -1     
+ Misses       9305     9163     -142     
Impacted Files Coverage Δ
...dialog/resourcefile-cloud-file-dialog.component.ts 91.74% <ø> (ø)
...sourcefile-picker/resourcefile-picker.component.ts 84.82% <ø> (ø)
...action/delete/delete-container-dialog.component.ts 42.85% <ø> (ø)
src/app/services/storage/storage-blob.service.ts 4.95% <0.00%> (ø)
...p/services/storage/storage-client-proxy-factory.ts 0.00% <0.00%> (ø)
.../app/services/storage/blob-storage-client-proxy.ts 2.12% <2.22%> (+2.12%) ⬆️
src/app/services/storage/storage-client.service.ts 20.00% <33.33%> (+2.60%) ⬆️
.../app/services/storage/storage-container.service.ts 7.24% <50.00%> (+1.44%) ⬆️
src/app/models/blob-container.ts 59.09% <83.33%> (+9.09%) ⬆️
.../@batch-flask/core/data/entity-view/entity-view.ts 100.00% <100.00%> (+11.11%) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19ae786...0d6b28f. Read the comment docs.

@gingi gingi force-pushed the feature/upgrade-azure-storage branch from 89ce8c8 to d12b498 Compare November 30, 2022 20:47
@gingi gingi force-pushed the feature/upgrade-azure-storage branch from d12b498 to 3a30691 Compare December 16, 2022 16:49
@gingi gingi force-pushed the feature/upgrade-azure-storage branch 2 times, most recently from afce78d to 1f23438 Compare December 23, 2022 19:47
@gingi gingi requested a review from dpwatrous December 23, 2022 20:21
dpwatrous
dpwatrous previously approved these changes Jan 6, 2023
@gingi gingi force-pushed the feature/upgrade-azure-storage branch from 1f23438 to f1f1a89 Compare January 9, 2023 17:47
@gingi gingi force-pushed the feature/upgrade-azure-storage branch from f1f1a89 to ee38fdf Compare January 11, 2023 14:50
@gingi gingi force-pushed the feature/upgrade-azure-storage branch from ee38fdf to 0d6b28f Compare January 11, 2023 15:32
@dpwatrous dpwatrous self-requested a review January 11, 2023 18:21
@gingi gingi merged commit f137c15 into master Jan 11, 2023
@gingi gingi deleted the feature/upgrade-azure-storage branch January 11, 2023 18:21
@cRui861
Copy link
Member

cRui861 commented Feb 1, 2023

Fixed #2637

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants