Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize on monaco 0.3x.x #2796

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Standardize on monaco 0.3x.x #2796

merged 1 commit into from
Sep 7, 2023

Conversation

dpwatrous
Copy link
Member

This is compatible with the ~0.31.0 version that the Azure Portal uses for ReactView blades

@dpwatrous dpwatrous force-pushed the dpwatrous/monaco-version branch 2 times, most recently from 3dbcf4c to 4379eff Compare September 7, 2023 20:58
@dpwatrous dpwatrous enabled auto-merge (squash) September 7, 2023 21:01
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #2796 (940282a) into main (1fa572a) will increase coverage by 0.01%.
The diff coverage is 14.28%.

❗ Current head 940282a differs from pull request most recent head 789170b. Consider uploading reports for the commit 789170b to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2796      +/-   ##
==========================================
+ Coverage   66.45%   66.47%   +0.01%     
==========================================
  Files        1232     1230       -2     
  Lines       33835    33813      -22     
  Branches     6161     6161              
==========================================
- Hits        22485    22476       -9     
+ Misses      11216    11203      -13     
  Partials      134      134              
Files Changed Coverage Δ
...top/src/@batch-flask/ui/editor/editor.component.ts 16.25% <0.00%> (-0.64%) ⬇️
...wer/text-file-viewer/text-file-viewer.component.ts 82.50% <100.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fa572a...789170b. Read the comment docs.

📢 Have feedback on the report? Share it here.

This is compatible with the ~0.31.0 version that the Azure Portal uses for ReactView blades
@dpwatrous dpwatrous force-pushed the dpwatrous/monaco-version branch from 4379eff to 789170b Compare September 7, 2023 22:49
@dpwatrous dpwatrous merged commit df863d9 into main Sep 7, 2023
@dpwatrous dpwatrous deleted the dpwatrous/monaco-version branch September 7, 2023 23:17
gingi pushed a commit that referenced this pull request Nov 9, 2023
This is compatible with the ~0.31.0 version that the Azure Portal uses for ReactView blades
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants