Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add vm extension related components & enable transpiling ESM js file for jest #2884

Merged
merged 38 commits into from
Apr 5, 2024
Merged

feat: add vm extension related components & enable transpiling ESM js file for jest #2884

merged 38 commits into from
Apr 5, 2024

Conversation

wanghoppe
Copy link
Member

@wanghoppe wanghoppe commented Jan 16, 2024 •
edited
Loading

image

image

@wanghoppe wanghoppe closed this Jan 16, 2024
@wanghoppe wanghoppe reopened this Jan 16, 2024
@wanghoppe wanghoppe marked this pull request as draft January 16, 2024 04:34
@wanghoppe wanghoppe changed the title Hoppe/vm exts feat: add vm extension related component & enable transpile ESM for jest Feb 2, 2024
@wanghoppe wanghoppe changed the title feat: add vm extension related component & enable transpile ESM for jest feat: add vm extension related component & enable transpiling ESM for jest Feb 2, 2024
@wanghoppe wanghoppe changed the title feat: add vm extension related component & enable transpiling ESM for jest feat: add vm extension related components & enable transpiling ESM for jest Feb 2, 2024
@wanghoppe wanghoppe changed the title feat: add vm extension related components & enable transpiling ESM for jest feat: add vm extension related components & enable transpiling ESM js file for jest Feb 2, 2024
@wanghoppe wanghoppe marked this pull request as ready for review February 2, 2024 09:36
@codecov Codecov
Copy link

codecov bot commented Feb 4, 2024 •
edited
Loading

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (1fafbc6) 67.28% compared to head (29b9eb3) 67.24%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2884      +/-   ##
==========================================
- Coverage   67.28%   67.24%   -0.04%     
==========================================
  Files        1236     1259      +23     
  Lines       33774    34184     +410     
  Branches     6231     6291      +60     
==========================================
+ Hits        22724    22987     +263     
- Misses      10896    11034     +138     
- Partials      154      163       +9
Files Coverage Δ
packages/bonito-ui/src/components/button.tsx 100.00% <ø> (ø)
...s/bonito-ui/src/components/data-grid/data-grid.tsx 92.15% <100.00%> (ø)
...src/components/data-grid/test-ignore-a11y-rules.ts 100.00% <100.00%> (ø)
...to-ui/src/components/editor/impl/MonacoWrapper.tsx 100.00% <100.00%> (ø)
...es/bonito-ui/src/components/panel/panel-footer.tsx 100.00% <100.00%> (ø)
packages/bonito-ui/src/components/panel/panel.tsx 100.00% <100.00%> (ø)
...nito-ui/src/components/property/property-field.tsx 59.25% <ø> (ø)
...nito-ui/src/components/property/property-group.tsx 95.83% <100.00%> (+0.59%) ⬆️
...onito-ui/src/components/property/text-property.tsx 85.71% <100.00%> (ø)
packages/bonito-ui/src/test-util/index.ts 100.00% <100.00%> (ø)
... and 9 more

... and 11 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fafbc6...29b9eb3. Read the comment docs.

gingi
gingi previously approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@gingi gingi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One small question about a file name; if by intention then ignore.

dpwatrous
dpwatrous requested changes Feb 8, 2024
View reviewed changes
dpwatrous
dpwatrous requested changes Feb 20, 2024
View reviewed changes
@wanghoppe wanghoppe enabled auto-merge (squash) February 22, 2024 02:54
@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.04663% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 67.25%. Comparing base (051d07d) to head (b645454).

❗ Current head b645454 differs from pull request most recent head 0e0c650. Consider uploading reports for the commit 0e0c650 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2884      +/-   ##
==========================================
- Coverage   67.29%   67.25%   -0.04%     
==========================================
  Files        1236     1259      +23     
  Lines       33777    34187     +410     
  Branches     6230     6291      +61     
==========================================
+ Hits        22729    22992     +263     
- Misses      10894    11032     +138     
- Partials      154      163       +9
Files Coverage Δ
packages/bonito-ui/src/components/button.tsx 100.00% <ø> (ø)
...s/bonito-ui/src/components/data-grid/data-grid.tsx 92.15% <100.00%> (ø)
...src/components/data-grid/test-ignore-a11y-rules.ts 100.00% <100.00%> (ø)
...to-ui/src/components/editor/impl/MonacoWrapper.tsx 100.00% <100.00%> (ø)
...es/bonito-ui/src/components/panel/panel-footer.tsx 100.00% <100.00%> (ø)
packages/bonito-ui/src/components/panel/panel.tsx 100.00% <100.00%> (ø)
...nito-ui/src/components/property/property-field.tsx 59.25% <ø> (ø)
...nito-ui/src/components/property/property-group.tsx 95.83% <100.00%> (+0.59%) ⬆️
...onito-ui/src/components/property/text-property.tsx 85.71% <100.00%> (ø)
packages/bonito-ui/src/test-util/index.ts 100.00% <100.00%> (ø)
... and 9 more

... and 11 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 051d07d...0e0c650. Read the comment docs.

@dpwatrous dpwatrous self-requested a review March 28, 2024 14:36
dpwatrous
dpwatrous previously approved these changes Mar 28, 2024
View reviewed changes
hoppe and others added 18 commits April 5, 2024 12:54
@dpwatrous
rename test tsBuildInfoFile & rename mock file name
b9d1ccb
@dpwatrous
add Hoppe todo
a2741e6
@dpwatrous
remove duplicated isolatedModules ts-jest setting
7f8f6c3
@dpwatrous
Add comments
3c9ff1b
@dpwatrous
change enableCollapse to disableCollapse in PropertyGroup
0d4a632
@dpwatrous
Fix typo in labelStyle prop name
b37d863
@dpwatrous
uncomment VmExtensionListDemo panel
0dff0bf
@dpwatrous
move jsdom mocks to setup-tests
d7f2b90
@dpwatrous
Add accessibility tests for node and pool vm extension lists
d3a9599
@dpwatrous
check if component is mounted when fetching data in useEffect
4e8480c
@dpwatrous
add generic type for data-grid
bb09f06
@dpwatrous
Fix test setup and remove unnecessary code
2d0113a
@dpwatrous
Add mockNodeTestMissingAPIs add address other comments
83dee88
@dpwatrous
modfiy test-mocks imports
9000d19
@wanghoppe @dpwatrous
remove unused
217d01d
@wanghoppe @dpwatrous
Remove tsconfig parameter from jest-common.js createConfig
58245e1
@wanghoppe @dpwatrous
Add moduleNameMapper to jest configuration
a1b12dd
@wanghoppe @dpwatrous
Remove unnecessary tsconfig.json reference in jest.config.js
db5aa85
@wanghoppe wanghoppe enabled auto-merge (squash) April 5, 2024 16:56
@dpwatrous
Copy link
Member

/azp run BatchExplorer - CI

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dpwatrous dpwatrous self-requested a review April 5, 2024 18:52
@dpwatrous
Copy link
Member

/azp run BatchExplorer - CI

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wanghoppe wanghoppe merged commit a093676 into main Apr 5, 2024
6 checks passed
@wanghoppe wanghoppe deleted the hoppe/vm-exts branch April 5, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpwatrous dpwatrous dpwatrous approved these changes

@gingi gingi gingi left review comments

@cRui861 cRui861 Awaiting requested review from cRui861 cRui861 is a code owner

@zfengms zfengms Awaiting requested review from zfengms zfengms is a code owner

@wiboris wiboris Awaiting requested review from wiboris wiboris is a code owner

@skapur12 skapur12 Awaiting requested review from skapur12 skapur12 is a code owner

@NickKouds NickKouds Awaiting requested review from NickKouds NickKouds is a code owner

@ReneOv-MSFT ReneOv-MSFT Awaiting requested review from ReneOv-MSFT ReneOv-MSFT is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wanghoppe @codecov-commenter @dpwatrous @gingi