Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates API, adds SKU service #2890

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Updates API, adds SKU service #2890

wants to merge 3 commits into from

Conversation

gingi
Copy link
Member

@gingi gingi commented Mar 4, 2024

  • Updates to API 2024-02-01 to support EOL property on supported SKUs (batchSupportEndOfLife)
  • Parametrizes translations (e.g., Hello, {name})
  • Adds SKU service to list supported VMs by type (virtual machine, cloud service), and a helper function to return EOL status

@gingi gingi force-pushed the shpaster/mgmt-2024-02-01 branch from ee416a3 to cb153ba Compare March 4, 2024 18:07
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 88.73239% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 67.32%. Comparing base (c560ef4) to head (cb153ba).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2890      +/-   ##
==========================================
+ Coverage   67.28%   67.32%   +0.04%     
==========================================
  Files        1236     1240       +4     
  Lines       33774    33842      +68     
  Branches     6182     6191       +9     
==========================================
+ Hits        22724    22785      +61     
- Misses      10896    10900       +4     
- Partials      154      157       +3     
Files Coverage Δ
...ges/bonito-core/src/localization/fake-localizer.ts 75.00% <100.00%> (+5.76%) ⬆️
...ges/bonito-core/src/localization/http-localizer.ts 71.87% <100.00%> (+2.90%) ⬆️
.../bonito-core/src/localization/localization-util.ts 100.00% <100.00%> (ø)
packages/service/src/constants.ts 100.00% <ø> (ø)
...ages/service/src/environment/batch-dependencies.ts 100.00% <100.00%> (ø)
...ckages/service/src/environment/environment-util.ts 90.90% <100.00%> (+2.02%) ⬆️
packages/service/src/sku/fake-sku-service.ts 100.00% <100.00%> (ø)
packages/service/src/sku/index.ts 100.00% <100.00%> (ø)
packages/service/src/test-util/fakes.ts 68.85% <100.00%> (+4.70%) ⬆️
.../arm-batch-rest/generated/batchManagementClient.ts 80.00% <0.00%> (ø)
... and 2 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c560ef4...cb153ba. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant