Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CryptoService tests use a more obviously fake key for tests #2895

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

dpwatrous
Copy link
Member

The current value looks too much like a real secret. Switched to a more obviously fake string.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.25%. Comparing base (90c2715) to head (eb1a204).

❗ Current head eb1a204 differs from pull request most recent head e1605c1. Consider uploading reports for the commit e1605c1 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2895   +/-   ##
=======================================
  Coverage   67.25%   67.25%           
=======================================
  Files        1259     1259           
  Lines       34187    34187           
  Branches     6291     6291           
=======================================
  Hits        22992    22992           
  Misses      11032    11032           
  Partials      163      163           
Files Coverage Δ
...ient/core/secure-data-store/crypto-service.spec.ts 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90c2715...e1605c1. Read the comment docs.

@dpwatrous dpwatrous merged commit b03851b into main Apr 12, 2024
6 checks passed
@dpwatrous dpwatrous deleted the dpwatrous/make-fake-key-obvious branch April 12, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants