Feature: Json forms support #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into feature/json-forms
-applied json editor in create task form
… form - remove unused import
… into feature/json-forms
timotheeguerin
commented
Nov 14, 2017
| @@ -44,13 +44,13 @@ export class DurationPickerComponent implements ControlValueAccessor { | |||
| @Input() public allowUnlimited: boolean = true; | |||
|
|
|||
| protected _propagateChange: (value: any) => void = null; | |||
| protected _duration: string; | |||
| protected _duration: any; | |||
There was a problem hiding this comment.
what is the type of this now? a duration? should set the type instead of any
timotheeguerin
commented
Nov 14, 2017
| * otherwise next smaller unit will be checked until last unit. | ||
| */ | ||
| private _setValueAndUnit() { | ||
| if (this.duration) { |
There was a problem hiding this comment.
can you do a guard check here instead of a big nested
timotheeguerin
commented
Nov 14, 2017
app/models/dtos/task-create.dto.ts
Outdated
|
|
||
| @DtoAttr() | ||
| public constraints?: ConstraintDto; | ||
| @DtoAttr() public constraints?: ConstraintDto; |
There was a problem hiding this comment.
Make constrains a dto class not just interface
timotheeguerin
commented
Nov 14, 2017
| @@ -2,6 +2,9 @@ import * as moment from "moment"; | |||
|
|
|||
| export class ProxyUtil { | |||
| public static decoratePool(pool: any): any { | |||
There was a problem hiding this comment.
we should be able to remove that completely now
timotheeguerin
commented
Nov 14, 2017
| @@ -7,6 +7,7 @@ import { NotificationService } from "app/components/base/notifications"; | |||
| import { SidebarRef } from "app/components/base/sidebar"; | |||
| import { JobCreateBasicDialogComponent } from "app/components/job/action"; | |||
| import { Pool, ServerError } from "app/models"; | |||
| // import { JobCreateDto } from "app/models/dtos"; | |||
-update duration picker duration type to moment.Duration and related update in job/task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #844