Fix DeploySubscriptionIds parameter type casting (#282)

Azure · May 10, 2022 · 229b144 · 229b144
1 parent 799ad52
commit 229b144
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/.github/workflows/0-everything.yml b/.github/workflows/0-everything.yml
@@ -107,10 +107,10 @@ jobs:
           -NvaPassword (ConvertTo-SecureString -String '${{secrets.NVA_PASSWORD}} '-AsPlainText -Force)
 
     - name: Deploy Subscriptions
-      if: github.event.inputs.subscriptionIds != ''
+      if: github.event.inputs.subscriptionIds != null
       run: |
         ./RunWorkflows.ps1 `
-          -DeploySubscriptionIds '${{github.event.inputs.subscriptionIds}}' `
+          -DeploySubscriptionIds @( ${{github.event.inputs.subscriptionIds}} ) `
           -EnvironmentName '${{github.event.inputs.environmentName}}' `
           -LoginServicePrincipalJson (ConvertTo-SecureString -String '${{secrets.ALZ_CREDENTIALS}}' -AsPlainText -Force) `
           -GitHubRepo ${env:GITHUB_REPOSITORY} `

diff --git a/.github/workflows/6-subscriptions.yml b/.github/workflows/6-subscriptions.yml
@@ -41,9 +41,10 @@ jobs:
         Install-Module powershell-yaml -Force
 
     - name: Deploy Subscriptions
+      if: github.event.inputs.subscriptionIds != null
       run: |
         ./RunWorkflows.ps1 `
-          -DeploySubscriptionIds '${{github.event.inputs.subscriptionIds}}' `
+          -DeploySubscriptionIds @( ${{github.event.inputs.subscriptionIds}} ) `
           -EnvironmentName '${{github.event.inputs.environmentName}}' `
           -LoginServicePrincipalJson (ConvertTo-SecureString -String '${{secrets.ALZ_CREDENTIALS}}' -AsPlainText -Force) `
           -GitHubRepo ${env:GITHUB_REPOSITORY} `

diff --git a/scripts/deployments/RunWorkflows.ps1 b/scripts/deployments/RunWorkflows.ps1
@@ -36,7 +36,7 @@ OF MERCHANTABILITY AND/OR FITNESS FOR A PARTICULAR PURPOSE.
     If true, run the NVA hub network workflow.
 
   .PARAMETER DeploySubscriptionIds
-    Comma separated list of subscription ids to run the subscription workflow against.
+    Comma separated list of quoted subscription ids to run the subscription workflow against.
 
   .PARAMETER EnvironmentName
     The name of the environment to run the workflow against.