Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DefaultSocketChannelConfiguration.SetOption is broken #68

Closed
nayato opened this issue Feb 10, 2016 · 0 comments · Fixed by #69
Closed

DefaultSocketChannelConfiguration.SetOption is broken #68

nayato opened this issue Feb 10, 2016 · 0 comments · Fixed by #69

Comments

@nayato
Copy link
Member

nayato commented Feb 10, 2016

DefaultSocketChannelConfiguration is missing SetOption overload resulting in failure to accept Socket-specific options through generic SetOption way.
@nayato nayato changed the title Enables setting options specific to DefaultSocketChannelConfiguration DefaultSocketChannelConfiguration.SetOption is broken Feb 10, 2016
@nayato nayato mentioned this issue Feb 10, 2016
Merged
nayato added a commit to nayato/DotNetty that referenced this issue Feb 10, 2016
@nayato
Enables setting options specific to DefaultSocketChannelConfiguration (…
8918942 
…fix Azure#68)

Motivation:
Fix a bug that breaks setting options specific to socket-based channel implementations

Modifications:
Added SetOption overload accepting socket-specific options to DefaultSocketChannelConfiguration

Result:
It is possible to modify send/receive buffer size and other settings through SetOption on Bootstrap.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enables setting options specific to DefaultSocketChannelConfiguration… nayato/DotNetty
1 participant
@nayato