Exposes SSL Stream and adds more TLS settings #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| public static TlsHandler Client(string targetHost) => new TlsHandler(false, null, targetHost, null); |
There was a problem hiding this comment.
should we leave these for common cases and internalize sslStreamFactory in such a case?
mtuchkov
force-pushed
the
tlsconfig
branch
3 times, most recently
from
35053b7 to
0ff6120
Compare
| } | ||
|
|
||
| public ClientTlsSettings(bool checkCertificateRevocation, X509CertificateCollection certificates, string targetHost) | ||
| : this(SslProtocols.Tls | SslProtocols.Tls11 | SslProtocols.Tls12, checkCertificateRevocation, certificates, targetHost) |
There was a problem hiding this comment.
shall we remove TLS 1.0 from here by default as well already?
There was a problem hiding this comment.
I don't want to do a breaking change. Let's do that in version 0.4.0
Motivation: Some important SSL Stream settings are hidden in the TlsHandler class Modifications: SSLStream is provided by user now via factory method; TLS settings extended Results: More advanced scenarios, like X509 client authentication, are possible to do now
|
lgtm |
|
addresses #60 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Some important SSL Stream settings are hidden in the TlsHandler class
Modifications:
SSLStream is provided by user now via factory method;
TLS settings extended
Results:
More advanced scenarios, like X509 client authentication, are possible to do now