Adds IEventExecutor.Schedule, proper cancellation of scheduled tasks #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| if (this.cancellationToken.IsCancellationRequested) | ||
| { | ||
| this.Promise.TrySetCanceled(); |
nayato
force-pushed
the
cancel-schedule
branch
2 times, most recently
from
085f4b9 to
6fb4ba4
Compare
|
|
||
| protected abstract void Execute(); | ||
|
|
||
| bool TrySetUncancelable() |
There was a problem hiding this comment.
Please re-use this method above if possible
|
Looks good |
Motivation: Allow for less GC when scheduling if Task-based API is not required. Allow for proper cleanup when canceling scheduled task so that associated resources can be cleaned up early. Modifications: - Moved out scheduled task implementations from AbstractScheduledEventExecutor - Introduced IScheduledTask and aligned IScheduledRunnable - Implemented removal of scheduled task upon its cancellation - Extra minor fixes - IByteBuffer.ToString(Encoding) honoring ArrayOffset - InternalLoggerFactory creating default logging factory lazily Result: Scheduled tasks that normally never fire (e.g. timeout handling) do not cause resources to be held up unnecessarily in memory for longer period of time if not necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Allow for less GC when scheduling if Task-based API is not required. Allow for proper cleanup when canceling scheduled task so that associated resources can be cleaned up early.
Modifications:
Result:
Scheduled tasks that normally never fire (e.g. timeout handling) do not cause resources to be held up unnecessarily in memory for longer period of time if not necessary.