Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMA Updates #1649

Merged
merged 36 commits into from
May 28, 2024
Merged

AMA Updates #1649

merged 36 commits into from
May 28, 2024

Conversation

arjenhuitema
Copy link
Contributor

@arjenhuitema arjenhuitema commented May 27, 2024

Overview/Summary

Introduces the use of a single centralized User Assigned Managed Identity for AMA. Policy and Initiative assignments have been updated with new parameters.

This PR fixes/adds/changes/removes

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Ensured contribution guidance is followed.
  • Updated relevant and associated documentation.
  • Updated the "What's New?" wiki page (located: /docs/wiki/whats-new.md)

@Springstone Springstone added PR: Safe to test 🧪 PRs can run more advanced tests that may deploy or access environments Area: Policy 📝 Issues / PR's related to Policy labels May 28, 2024
Copy link
Member

@Springstone Springstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes and a question. Can you also please add a little more to What's New / AMA about how we've implemented the change to single UAMI, in particular what we default to now in ALZ portal

"userAssignedIdentityResourceId": "[concat('/subscriptions/', variables('singleVsDedicatedMgmtSub'), '/resourceGroups/', variables('platformRgNames').mgmtRg, '/providers/Microsoft.ManagedIdentity/userAssignedIdentities/', variables('platformResourceNames').userAssignedIdentity)]"

Otherwise an outstanding PR!

…-UserAssignedManagedIdentity-VMInsights.json

Co-authored-by: Sacha Narinx <Springstone@users.noreply.github.com>
@Springstone Springstone merged commit 000fcd2 into policy-refresh-q3fy24 May 28, 2024
2 of 4 checks passed
@Springstone Springstone deleted the feature-ama-updates branch May 28, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Policy 📝 Issues / PR's related to Policy PR: Safe to test 🧪 PRs can run more advanced tests that may deploy or access environments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants