Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating exemption for securityContacts to reflect the expected, as of both MCSB and what the policy deploys #1916

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

JonasCordsen
Copy link
Contributor

Updating exemption for securityContacts to reflect the expected, as of both MCSB and what the policy deploys

Overview/Summary

The securityContacts does not evaluate if the notificationsByRole is set, so if previous settings had been made, this policy would be compliant, but he audit from MCSB would be non-compliant

This PR fixes/adds/changes/removes

  1. Adding an existenceCondition to ensure that notificationsByRole state is on and that in contains the role Owner

Breaking Changes

  1. None

Testing Evidence

Adding the definition to my own branch, and ensuring the when to non-compliant and that a remediation of the policy caused the subscriptions to become compliant

Testing URLs

The below URLs can be updated where the placeholders are, look for {YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also} & {YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also}, to allow you to test your portal deployment experience.

Please also replace the curly brackets on the placeholders {}

Azure Public

Deploy To Azure

Azure US Gov (Fairfax)

Deploy To Azure

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Ensured contribution guidance is followed.
  • Updated relevant and associated documentation.
  • Updated the "What's New?" wiki page (located: /docs/wiki/whats-new.md)

@JonasCordsen JonasCordsen requested a review from a team as a code owner February 6, 2025 12:46
@JonasCordsen
Copy link
Contributor Author

@Springstone Hey, j just updated with a another linter so it follows what you require, so need a new review :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants