Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RI refresh (Wingtip/AdvWorks) #345

Merged
merged 7 commits into from
Dec 8, 2020
Merged

RI refresh (Wingtip/AdvWorks) #345

merged 7 commits into from
Dec 8, 2020

Conversation

krnese
Copy link
Contributor

@krnese krnese commented Dec 4, 2020 •
edited
Loading

This PR fixes

  • Correcting deployment names
  • Added 4 policies for AKS
  • Moving from custom policy to built-in for VM Backup using Azure Backup
  • Updated UX
  • Adding UX and granularity in policyAssignment for ASC & Defender options per tier (servers, SQL, AppServices, KeyVault, Storage, Kubernetes, ContainerRegistries, DNS, ARM)

@krnese krnese added the enhancement New feature or request label Dec 4, 2020
@krnese krnese requested a review from daltondhcp December 4, 2020 17:47
@krnese krnese changed the title AKS refresh RI refresh (Wingtip/AdvWorks) Dec 6, 2020
@krnese krnese linked an issue Dec 7, 2020 that may be closed by this pull request
Invalid/Incorrect role definition Id for backup policy for wingtips/adventureworks #346
Closed
daltondhcp
daltondhcp previously approved these changes Dec 7, 2020
View reviewed changes
@krnese krnese added the policy label Dec 8, 2020
@krnese krnese merged commit c9882fc into Azure:main Dec 8, 2020
@krnese krnese deleted the adv-commenting branch December 8, 2020 15:39
@paulgrimley paulgrimley mentioned this pull request Apr 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daltondhcp daltondhcp daltondhcp approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request policy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid/Incorrect role definition Id for backup policy for wingtips/adventureworks
2 participants
@krnese @daltondhcp