Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adventure Works RI Update (Jan 2021) #405

Merged
merged 4 commits into from
Jan 25, 2021
Merged

Adventure Works RI Update (Jan 2021) #405

merged 4 commits into from
Jan 25, 2021

Conversation

krnese
Copy link
Contributor

@krnese krnese commented Jan 22, 2021 •
edited
Loading

This PR fixes

  • Added policy to deny subnet without User-Defined-Route
  • Added policy to deny peering outside of the subscription (e.g., sandbox environments)
  • Corrected RBAC on policies invoked at subscription scope to include 'Contributor' to ensure required permissions to create resource groups
  • Updated Adventure Works to optionally peer corp connected landing zones (maximum 10 for now) to hub virtual network, if hub is configured and created during deployment
  • Azure Policy to govern corp connected landing zone's virtual networks

@krnese krnese changed the title policy update Adventure Works RI Update (Jan 2021) Jan 25, 2021
@krnese krnese requested a review from uday31in January 25, 2021 20:53
@krnese krnese merged commit 10d6bbb into Azure:main Jan 25, 2021
This was linked to issues Feb 1, 2021
Peering between connectivity and landingzone subscriptions #385
Closed
ES with hub and spoke architecture does not deploy the spoke VNet and peering #400
Closed
@paulgrimley paulgrimley mentioned this pull request Apr 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daltondhcp daltondhcp daltondhcp approved these changes

@uday31in uday31in Awaiting requested review from uday31in

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@krnese @daltondhcp