-
Notifications
You must be signed in to change notification settings - Fork 993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ri refreshv3 #429
Merged
Merged
Ri refreshv3 #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uday31in
previously approved these changes
Feb 11, 2021
@krnese Please could you add an additional parameter and some additional validation to the Here is a new Improvements
"Properties": {
"Description": "Deploys NSG flow logs and traffic analytics to a storageaccountid with a specified retention period. This must be assigned once for each in-scope region because the storage account and NSG must be in the same region. Must also be assigned at a MG Scope that covers the LA workspace and NetworkwatcherRG.",
"DisplayName": "Deploys NSG flow logs and traffic analytics for a region",
"Mode": "All",
"Parameters": {
"retention": {
"type": "Integer",
"metadata": {
"displayName": "Retention (days)"
},
"defaultValue": 5
},
"storageAccountResourceId": {
"type": "String",
"metadata": {
"displayName": "Storage Account Resource Id",
"strongType": "Microsoft.Storage/storageAccounts"
}
},
"trafficAnalyticsInterval": {
"type": "Integer",
"metadata": {
"displayName": "Traffic Analytics processing interval mins (10/60)"
},
"defaultValue": 60,
"allowedValues": [
10,
60
]
},
"flowAnalyticsEnabled": {
"type": "Boolean",
"metadata": {
"displayName": "Enable Traffic Analytics"
},
"defaultValue": false,
"allowedValues": [
true,
false
]
},
"logAnalytics": {
"type": "String",
"metadata": {
"strongType": "omsWorkspace",
"displayName": "Resource ID of Log Analytics workspace",
"description": "Select Log Analytics workspace from dropdown list. If this workspace is outside of the scope of the assignment you must manually grant 'Log Analytics Contributor' permissions (or similar) to the policy assignment's principal ID."
},
"defaultValue": ""
},
"effect": {
"type": "String",
"metadata": {
"displayName": "Effect",
"description": "Enable or disable the execution of the policy"
},
"allowedValues": [
"DeployIfNotExists",
"Disabled"
],
"defaultValue": "DeployIfNotExists"
}
} "PolicyRule": {
"if": {
"allOf": [
{
"field": "type",
"equals": "Microsoft.Network/networkSecurityGroups"
},
{
"field": "location",
"equals": "[parameters('targetRegion')]"
}
]
}, |
uday31in
approved these changes
Mar 1, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes