Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Option to select Firewall SKU #793

Merged
merged 19 commits into from
Sep 8, 2021
Merged

Add Option to select Firewall SKU #793

merged 19 commits into from
Sep 8, 2021

Conversation

marvinbuss
Copy link
Contributor

@marvinbuss marvinbuss commented Sep 8, 2021 •
edited
Loading

Overview/Summary

Replace this with a brief description of what this Pull Request fixes, changes, etc.

This PR fixes/adds/changes/removes

  1. Adds Option to select Firewall SKU

Breaking Changes

  1. None

Testing Evidence

image

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.
  • Updated the "What's New?" wiki page (located: /docs/wiki/whats-new.md)

marvinbuss and others added 14 commits June 29, 2021 18:42
@marvinbuss marvinbuss added enhancement New feature or request engineering engineering work labels Sep 8, 2021
@marvinbuss marvinbuss self-assigned this Sep 8, 2021
@marvinbuss marvinbuss linked an issue Sep 8, 2021 that may be closed by this pull request
Feature Request: Enable option to deploy Azure Firewall Premium in RI #790
Closed
@marvinbuss marvinbuss marked this pull request as ready for review September 8, 2021 08:53
@marvinbuss marvinbuss requested a review from a team as a code owner September 8, 2021 08:53
@daltondhcp daltondhcp self-requested a review September 8, 2021 09:07
@marvinbuss marvinbuss requested a review from a team as a code owner September 8, 2021 14:00
@marvinbuss
Copy link
Contributor Author

@daltondhcp I added the Infor to the What's new page

daltondhcp
daltondhcp reviewed Sep 8, 2021
View reviewed changes
eslzArm/eslz-portal.json Outdated Show resolved Hide resolved
@daltondhcp
Copy link
Contributor

Apart from above comment - tested deployments for both vWAN and H&S and works well! 👏

@marvinbuss
Copy link
Contributor Author

@daltondhcp Please check the updates. It is all done.

daltondhcp
daltondhcp approved these changes Sep 8, 2021
View reviewed changes
Copy link
Contributor

@daltondhcp daltondhcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@marvinbuss marvinbuss merged commit 4a8a6f5 into Azure:main Sep 8, 2021
@marvinbuss marvinbuss deleted the feature/firewall_sku branch September 8, 2021 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daltondhcp daltondhcp daltondhcp approved these changes

Assignees

@marvinbuss marvinbuss

Labels
engineering engineering work enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Enable option to deploy Azure Firewall Premium in RI
2 participants
@marvinbuss @daltondhcp