Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASC built-ins #835

Merged
merged 7 commits into from
Oct 22, 2021
Merged

ASC built-ins #835

merged 7 commits into from
Oct 22, 2021

Conversation

krnese
Copy link
Contributor

@krnese krnese commented Oct 21, 2021

Overview/Summary

Replace this with a brief description of what this Pull Request fixes, changes, etc.

This PR fixes/adds/changes/removes

  1. Removes custom policyDefinitions for ASC Defender configuration for services, as they are moved to built-ins.
  2. Updated custom policySet to reference the new built-in policyDefinitions for ASC Defender per service
  3. Updated policy effect to be DeployIfNotExists or Disabled
  4. Added ASC Defender policy for open-source relational databases
  5. Updated ASC Policy Initiative to v 2.0.0

Breaking Changes

N/A

@krnese krnese added enhancement New feature or request engineering engineering work labels Oct 21, 2021
@krnese krnese requested a review from a team as a code owner October 21, 2021 10:54
@krnese krnese linked an issue Oct 21, 2021 that may be closed by this pull request
Move from custom ASC defender policies to built-in #733
Closed
@krnese krnese mentioned this pull request Oct 21, 2021
Closed
6 tasks
@jtracey93
Copy link
Collaborator

Can we please ensure the docs are updated, especially the "What's New?" Wiki page so everyone can see the changes here 👍 🙂

@krnese krnese requested a review from a team as a code owner October 21, 2021 12:27
daltondhcp
daltondhcp previously approved these changes Oct 21, 2021
View reviewed changes
jtracey93
jtracey93 requested changes Oct 21, 2021
View reviewed changes
docs/wiki/Whats-new.md Show resolved Hide resolved
docs/wiki/Whats-new.md Show resolved Hide resolved
@krnese krnese merged commit 5ba2b46 into Azure:main Oct 22, 2021
@krnese krnese deleted the asc-built-ins branch October 22, 2021 14:29
@krnese krnese linked an issue Oct 22, 2021 that may be closed by this pull request
Pricing Tier for VMs parameter in Policy Assignment #833
Closed
@krnese krnese mentioned this pull request Oct 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daltondhcp daltondhcp daltondhcp approved these changes

@jtracey93 jtracey93 jtracey93 approved these changes

Assignees
No one assigned
Labels
engineering engineering work enhancement New feature or request policy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pricing Tier for VMs parameter in Policy Assignment Move from custom ASC defender policies to built-in
3 participants
@krnese @jtracey93 @daltondhcp