Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict mode in 2.9.x seems to prevent changing messaging mode #2167

Closed
NoTuxNoBux opened this issue Feb 1, 2024 · 2 comments
Closed

Strict mode in 2.9.x seems to prevent changing messaging mode #2167

NoTuxNoBux opened this issue Feb 1, 2024 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@NoTuxNoBux
Copy link

Describe the bug
In 2.8.x, I could pass --strict --messagingmode=Samples to use strict mode and maintain the Samples messaging mode. In 2.9.3, Enabling strict mode seems to force a single format (I think it's the PubSub one) and trying to change the messaging mode appears to have no effect.

To Reproduce
Steps to reproduce the behavior:

  1. Start the publisher with --strict --messagingmode=Samples
  2. Observe Samples not being used as data format.

Expected behavior
Samples is used as data format, or alternatively a message in the command line options reference that both modes are incompatible if this is the case. Currently it just mentions the defaults change with strict mode, but not that it's incompatible.

Desktop (please complete the following information):

  • OS: Linux x86-64

Additional context
Leaving out --strict on 2.9.3 fixes the issue, but probably also disables strict mode.

Not sure if relevant, but I'm building a custom SignalR transport modelled after the MQTT one, so in my transport is where I'm observing the data formats.

@marcschier
Copy link
Collaborator

Hi, you are correct.

--strict is new in 2.9, it is one of the command line options silently discarded in 2.8. Strict means strict compliance with OPC UA Part 6/14. Samples mode was our invention before Part14 even existed.

That said, a log message and better documentation would be very useful, agreed.

@marcschier marcschier added the bug Something isn't working label Feb 1, 2024
@marcschier marcschier added this to the 2.9.5 milestone Feb 1, 2024
marcschier added a commit that referenced this issue Feb 7, 2024
* Update docs and sample
* Remove connect/disconnect API
* Allow overriding of strict compliance with messaging mode (#2167)
@marcschier
Copy link
Collaborator

Instead of logging / throwing, now allowing the overriding (just like other settings can be overriden, e.g., namespace mode) and updated the documentation and cli options as such.

@marcschier marcschier modified the milestones: 2.9.5, 2.9.4 Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants