Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Geneva mdm Docker checks #77

Merged
merged 4 commits into from
Mar 19, 2024
Merged

Fix Geneva mdm Docker checks #77

merged 4 commits into from
Mar 19, 2024

Conversation

PPPW
Copy link
Contributor

@PPPW PPPW commented Feb 16, 2024

  • Check if Docker image already pulled
  • Fix the condition to check if the container is already running
  • Remove the ID/UID so that the dashboard JSON can be copy-pasted

Validated everything in our test VMs.

@PPPW
Copy link
Contributor Author

PPPW commented Mar 7, 2024

@rafsalas19 Could you take a look at this PR when you get a chance? Thanks!

@rafsalas19 rafsalas19 merged commit f17bdc7 into Azure:main Mar 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafsalas19 rafsalas19 rafsalas19 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PPPW @rafsalas19