-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] Normalizer multi modal/flexible support refactor #143
Merged
rlundeen2
merged 47 commits into
Azure:main
from
rlundeen2:users/rlundeen/4_5_normalizer_multi_modal_rebase
Apr 16, 2024
Merged
[FEAT] Normalizer multi modal/flexible support refactor #143
rlundeen2
merged 47 commits into
Azure:main
from
rlundeen2:users/rlundeen/4_5_normalizer_multi_modal_rebase
Apr 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cseifert1
reviewed
Apr 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some initial comments. this was a massive refactor. great job! Thank you for tackling this, Rich!
jbolor21
reviewed
Apr 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some small comments, but great job with this!!!
romanlutz
approved these changes
Apr 15, 2024
Co-authored-by: Roman Lutz <romanlutz13@gmail.com>
Co-authored-by: Roman Lutz <romanlutz13@gmail.com>
romanlutz
approved these changes
Apr 16, 2024
rlundeen2
changed the title
[DRAFT] Normalizer multi modal/flexible support refactor
[FEAT] Normalizer multi modal/flexible support refactor
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Architecture of pyrit began by having a string "prompt" that ran through. Converters took a string, targets took a string, and orchestrators sent a string.
This proved too limited since certain converters and targets can take multiple input types (sometimes simultaneously), and they are handled differently.
This refactor adds PromptRequestResponse objects that adds more flexibility in how we send and process prompts.
Tests and Documentation