Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT Refactoring Dalle Target #156

Merged
merged 24 commits into from
Apr 27, 2024
Merged

MAINT Refactoring Dalle Target #156

merged 24 commits into from
Apr 27, 2024

Conversation

jbolor21
Copy link
Contributor

Description

refactoring DALLE target to use new database scheme and normalizer

@jbolor21 jbolor21 changed the title [DRAFT] [MAINT] Refactoring Dalle Target [DRAFT] MAINT Refactoring Dalle Target Apr 22, 2024
cseifert1
cseifert1 reviewed Apr 22, 2024
View reviewed changes
Copy link
Contributor

@cseifert1 cseifert1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bolor, does this include 2540?

@jbolor21 jbolor21 changed the title [DRAFT] MAINT Refactoring Dalle Target MAINT Refactoring Dalle Target Apr 25, 2024
@jbolor21 jbolor21 marked this pull request as ready for review April 26, 2024 21:15
romanlutz
romanlutz reviewed Apr 26, 2024
View reviewed changes
pyrit/prompt_target/prompt_chat_target/openai_chat_target.py Outdated Show resolved Hide resolved
tests/target/test_dall_e_target.py Outdated Show resolved Hide resolved
pyrit/prompt_target/dall_e_target.py Outdated Show resolved Hide resolved
pyrit/prompt_target/dall_e_target.py Outdated Show resolved Hide resolved
pyrit/prompt_target/dall_e_target.py Outdated Show resolved Hide resolved
@jbolor21 jbolor21 merged commit 949fafb into Azure:main Apr 27, 2024
5 checks passed
@jbolor21 jbolor21 deleted the users/bjagdagdorj/dalle_refactor branch April 27, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdheekonda rdheekonda rdheekonda left review comments

@romanlutz romanlutz romanlutz left review comments

@cseifert1 cseifert1 cseifert1 left review comments

@rlundeen2 rlundeen2 rlundeen2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jbolor21 @cseifert1 @romanlutz @rdheekonda @rlundeen2