Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: add xstest dataset #320

Merged
merged 17 commits into from
Aug 14, 2024
Merged

Conversation

KutalVolkan
Copy link
Contributor

Description:

This PR adds the fetch_xstest_examples function to the pyrit.datasets package, enabling the import of the XSTest dataset as a PromptDataset. It also includes corresponding unit tests to verify the functionality.

Changes:

  • pyrit/datasets/__init__.py: Added fetch_xstest_examples.
  • pyrit/datasets/fetch_example_datasets.py: Implemented fetch_xstest_examples.
  • tests/test_xstest.py: Added unit tests for fetch_xstest_examples.

Related Issue:

KutalVolkan and others added 10 commits August 3, 2024 13:37
…d fixed issues across all files.- Updated .gitignore for better exclusion.- Import changes in many_shot_jailbreak.ipynb and .py - Updated datasets initialization and fetching scripts.- Added new seclists_bias_testing notebooks and scripts.
…ed .gitignore to ignore unnecessary files.- Modified many_shot_jailbreak.ipynb and many_shot_jailbreak.py with improvements.- Modified seclists_bias_testing.ipynb and seclists_bias_testing.py for better functionality.- Updated fetch_example_datasets.py for enhanced placeholder management.Next steps:- Write comprehensive unit and integration tests to validate functionality.
…chestrator logic in seclists_bias_testing.ipynb
…chestrator logic in seclists_bias_testing.ipynb
@romanlutz
Copy link
Contributor

Hey @KutalVolkan! Thanks for the seclists bias PR, just merged 🎉 Feel free to update this one accordingly.

@KutalVolkan
Copy link
Contributor Author

Hey @KutalVolkan! Thanks for the seclists bias PR, just merged 🎉 Feel free to update this one accordingly.

The updates are ready for your review. Any feedback is welcome, and I'm ready to make any further adjustments as needed. Thank you for your great support!

@KutalVolkan KutalVolkan marked this pull request as ready for review August 12, 2024 10:25
@romanlutz romanlutz changed the title [DRAFT] Feature/add xstest dataset FEAT: add xstest dataset Aug 12, 2024
@romanlutz
Copy link
Contributor

It's showing that there are merge conflicts with main. Still seeing all the seclists bias changes in this one. Happy to take a look when that's resolved since it's a lot of lines otherwise 🙂

@KutalVolkan
Copy link
Contributor Author

KutalVolkan commented Aug 12, 2024

It's showing that there are merge conflicts with main. Still seeing all the seclists bias changes in this one. Happy to take a look when that's resolved since it's a lot of lines otherwise 🙂

Hello Roman,

Are there still merge conflicts? I tried to fix them by merging with the PyRIT main branch. Let me know if it did not work out. Thank you!

Copy link
Contributor

@romanlutz romanlutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Just a couple small things, then it's ready to merge IMO

@romanlutz
Copy link
Contributor

@KutalVolkan can you fix the build pipeline issue(s) and merge latest main in? I think we're essentially done. There's the nit-comment about removing copyright but otherwise I'm happy to hit "merge"

@KutalVolkan KutalVolkan force-pushed the feature/add-xstest-dataset branch from 9e9344c to 9d4adde Compare August 14, 2024 06:00
@KutalVolkan
Copy link
Contributor Author

@KutalVolkan can you fix the build pipeline issue(s) and merge latest main in? I think we're essentially done. There's the nit-comment about removing copyright but otherwise I'm happy to hit "merge"

Hello Roman,

Merged with the PyRIT main branch and fixed the build pipline issue. Let me know if it did not work out. Thank you :)

@romanlutz romanlutz merged commit b9f3cee into Azure:main Aug 14, 2024
5 checks passed
@KutalVolkan KutalVolkan deleted the feature/add-xstest-dataset branch August 15, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants