-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AML Endpoint Bug Fix and Refactor #40
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results94 tests +1 94 ✅ +1 9s ⏱️ ±0s Results for commit 85ff67f. ± Comparison against base commit b37578b. This pull request removes 8 and adds 9 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
6 tasks
rdheekonda
reviewed
Feb 13, 2024
rdheekonda
reviewed
Feb 13, 2024
rdheekonda
reviewed
Feb 13, 2024
rdheekonda
reviewed
Feb 13, 2024
rdheekonda
reviewed
Feb 13, 2024
rdheekonda
reviewed
Feb 13, 2024
romanlutz
reviewed
Feb 13, 2024
Co-authored-by: Roman Lutz <romanlutz13@gmail.com>
…m/Azure/PyRIT into users/rlundeen/2_9_aml_thread_fix
rdheekonda
approved these changes
Feb 13, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Users were encountering a bug with multiple loops when using the AML endpoint. When investigating, there was another issue - it turns out the header of the request had changed (another bug). How it was setup,
AMLOnlineEndpointChat
was difficult to debug, which made root causing these two other bugs difficult.This PR fixes both the above bugs and makes the code easier to debug going forward.
aml_endpoints.ipynb
net_utility
to standardize network request and backoff logicaml_online_endpoint_chat
complete_chat_async
as a requirement for theChatSupport
interface. It has perf benefits with a lot of threads but I'd like to get to a stable place first, and to add it back, it would have to be rewrittenTests
Documentation