Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sub port interface high level design #420

Merged
merged 32 commits into from
Oct 9, 2019
Merged

Sub port interface high level design #420

merged 32 commits into from
Oct 9, 2019

Conversation

wendani
Copy link
Contributor

@wendani wendani commented Jul 10, 2019

Signed-off-by: Wenda Ni wenni@microsoft.com

@wendani
Initial sub port interface high level design
0c6acad 
Signed-off-by: Wenda Ni <wenni@microsoft.com>
@wendani wendani mentioned this pull request Jul 12, 2019
Merged
@wendani wendani requested a review from jipanyang July 12, 2019 20:58
@wendani
Address comments
d566d95 
Signed-off-by: Wenda Ni <wenni@microsoft.com>
prsunny
prsunny reviewed Aug 6, 2019
View reviewed changes
doc/sonic-sub-port-intf-hld.md Show resolved Hide resolved
doc/sonic-sub-port-intf-hld.md Show resolved Hide resolved
doc/sonic-sub-port-intf-hld.md Show resolved Hide resolved
doc/sonic-sub-port-intf-hld.md Outdated Show resolved Hide resolved
jipanyang
jipanyang reviewed Aug 7, 2019
View reviewed changes
Copy link
Contributor

@jipanyang jipanyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to have a separate subport manager handling the sub port configurations?

At intfmgrd, it is more about ip/ipv6 address and vrf config. Management of sub port looks closer to lag/vlan objects.

jipanyang
jipanyang reviewed Aug 7, 2019
View reviewed changes
doc/sonic-sub-port-intf-hld.md Outdated Show resolved Hide resolved
doc/sonic-sub-port-intf-hld.md Show resolved Hide resolved
@wendani wendani force-pushed the sub_port_master branch 4 times, most recently from 73a014d to b169451 Compare August 8, 2019 02:28
@wendani
Add implementation reference
3262983 
Signed-off-by: Wenda Ni <wenni@microsoft.com>
@wendani
Amend references
2178490 
Signed-off-by: Wenda Ni <wenni@microsoft.com>
@wendani
Correct typo
b63738f 
Signed-off-by: Wenda Ni <wenni@microsoft.com>
@wendani wendani mentioned this pull request Sep 10, 2019
Merged
@wendani
Update table of contents; update references
2b2de9a 
Signed-off-by: Wenda Ni <wenni@microsoft.com>
@BaluAlluru BaluAlluru mentioned this pull request Sep 10, 2019
Open
@wendani
Change wording
b7604a7 
Signed-off-by: Wenda Ni <wenni@microsoft.com>
@wendani
Update usage examples
96a2ae6 
Signed-off-by: Wenda Ni <wenni@microsoft.com>
@wendani
Add CLI design for changing admin status
52d91cb 
Signed-off-by: Wenda Ni <wenni@microsoft.com>
@wendani
Add an APPL_DB entry example for IPv6
1aa11ca 
Signed-off-by: Wenda Ni <wenni@microsoft.com>
@wendani
Add a STATE_DB entry example for IPv6
0393b53 
Signed-off-by: Wenda Ni <wenni@microsoft.com>
@wendani wendani mentioned this pull request Sep 12, 2019
Merged
@wendani
Amend references
2219297 
Signed-off-by: Wenda Ni <wenni@microsoft.com>
@wendani
Copy link
Contributor Author

wendani commented Sep 14, 2019

🚢

@wendani wendani mentioned this pull request Sep 18, 2019
Merged
@wendani
Amend reference on add/del ip address CLI
a3e669e 
Signed-off-by: Wenda Ni <wenni@microsoft.com>
prsunny
prsunny approved these changes Sep 18, 2019
View reviewed changes
Copy link
Contributor

@prsunny prsunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment on the use of STATE_DB tables. Within the same process you may not want to sequence it by writing PORT and LAG tables and then waiting on it, but can be handled by a local cache.

@wendani
Copy link
Contributor Author

wendani commented Sep 27, 2019 •
edited
Loading

Yes. sub-interface <Port/PortChannel> can coexist with Vlan interface at the same time. You can stitch Fig. 3 and Fig. 1 together to get a complete picture. Looking right from VRF0 in Fig. 3, what you see is Fig. 1.

Vlan10 and Ethernet64.10 can bind to different VRFs independently.

#420 (comment)

@lguohan lguohan merged commit 832fafd into sonic-net:master Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tieguoevan tieguoevan tieguoevan left review comments

@rck-innovium rck-innovium rck-innovium left review comments

@lguohan lguohan lguohan approved these changes

@itaibaz itaibaz itaibaz approved these changes

@prsunny prsunny prsunny approved these changes

@venkatmahalingam venkatmahalingam venkatmahalingam approved these changes

@stcheng stcheng Awaiting requested review from stcheng

@zhenggen-xu zhenggen-xu Awaiting requested review from zhenggen-xu

@qiluo-msft qiluo-msft Awaiting requested review from qiluo-msft

@jipanyang jipanyang Awaiting requested review from jipanyang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@wendani @lguohan @tieguoevan @itaibaz @qiluo-msft @prsunny @jipanyang @venkatmahalingam @preetham-singh @rck-innovium