Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support sub port interface admin status change #638

Merged
merged 7 commits into from
Oct 3, 2019

Conversation

wendani
Copy link
Contributor

@wendani wendani commented Sep 10, 2019

- What I did
Implement HLD sonic-net/SONiC#420

- How I did it

- How to verify it
On mlnx dut

alias mode:

$ show  interfaces naming_mode
alias
$ sudo config interface shutdown etp17.10

$ redis-cli -n 4 hgetall "VLAN_SUB_INTERFACE|Ethernet64.10"
1) "admin_status"
2) "down"

$ redis-cli -n 0 hgetall "INTF_TABLE:Ethernet64.10"
1) "admin_status"
2) "down"
$ sudo config interface startup etp17.10

$ redis-cli -n 4 hgetall "VLAN_SUB_INTERFACE|Ethernet64.10"
1) "admin_status"
2) "up"

$ redis-cli -n 0 hgetall "INTF_TABLE:Ethernet64.10"        
1) "admin_status"
2) "up"

default mode:

$ show interfaces naming_mode 
default
$ sudo config interface shutdown Ethernet64.10

$ redis-cli -n 4 hgetall "VLAN_SUB_INTERFACE|Ethernet64.10"
1) "admin_status"
2) "down"

$ redis-cli -n 0 hgetall "INTF_TABLE:Ethernet64.10"
1) "admin_status"
2) "down"
$ sudo config interface startup Ethernet64.10

$ redis-cli -n 4 hgetall "VLAN_SUB_INTERFACE|Ethernet64.10"
1) "admin_status"
2) "up"

$ redis-cli -n 0 hgetall "INTF_TABLE:Ethernet64.10"
1) "admin_status"
2) "up"

- Previous command output (if the output of a command-line utility has changed)

- New command output (if the output of a command-line utility has changed)

-->

@wendani
Copy link
Contributor Author

wendani commented Sep 10, 2019

retest this please

@wendani
Copy link
Contributor Author

wendani commented Sep 12, 2019

retest this please

Signed-off-by: Wenda Ni <wenni@microsoft.com>
@wendani
Copy link
Contributor Author

wendani commented Sep 13, 2019

retest this please

Signed-off-by: Wenda Ni <wenni@microsoft.com>
@prsunny
Copy link
Contributor

prsunny commented Sep 19, 2019

Is this PR a super set of this one?

@wendani
Copy link
Contributor Author

wendani commented Sep 19, 2019

Yes. #638 (comment)

@wendani wendani merged commit bb03f6c into sonic-net:master Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants