-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Agent update refactor supports GA versioning #2810
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
053e9ae
agent update refactor (#2706)
nagworld9 9943b39
report GA versioning supported feature. (#2752)
nagworld9 23bf29a
Don't report SF flag idf auto update is disabled (#2754)
nagworld9 7b7c955
fix uts (#2759)
nagworld9 23a5206
agent versioning test_suite (#2770)
nagworld9 87f8364
logging manifest type and don't log same error until next period in a…
nagworld9 5b118d9
Added self-update time window. (#2794)
nagworld9 b8f1592
Wait and retry for rsm goal state (#2801)
nagworld9 a90d7aa
Not sharing agent update tests vms and added scenario to daily run (#…
nagworld9 f6b07a7
merge conflicts
nagworld9 e9c7fee
address comments
nagworld9 7e66d54
address comments
nagworld9 22de261
additional comments addressed
nagworld9 7b6d2e3
fix pylint warning
nagworld9 42588db
Merge branch 'develop' into new-ga-update
nagworld9 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If only needed by the tests, this should be a Debug/experimental option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is this different than auto update?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can't use the auto update flag because of legacy behavior associated with it where agent fallback to daemon version which we don't want as our e2e tests need to run on test version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nagworld9 - did we decide this to expose this option to the user? if yes, let's add it to README, if not, let's make it Debug
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, what is the difference between GAUpdates.Enabled and Debug.EnableGAVersioning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this is not exposed to the user. I'll change to debug.
Debug.EnableGAVersioning- This flag is like kill switch. Once this is trun off our code will go to self update path.
GAUpdates.Enabled- This flag is to stop the agent updates. Only used in e2e tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll change as part of next work item.