This commit is fixing the network-manager package detection (use dpkg-query instead of dpkg -l) #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using dpkg-query -s is more appropriate than using dpkg -l and grep -q. The only way to have 0 returned by dpkg-query -s is to have NM installed and dpkg -l |grep -q may return 1 if the package is not yet known in the base (for instance, right after installing). Signed-off-by: Arnaud Patard <apatard@hupstream.com>
ghost
assigned 
|
Hello Arnaud! Apologies for the delay taking a look at this. I'm now working on this project and I'll be taking on these requests moving forward. Thanks! |
Conflicts: waagent Signed-off-by: Arnaud Patard <apatard@hupstream.com>
waagent is trying to detect if there's a virtual cdrom by grepping fdisk output, except that the output is different if we're not using en locale. Use LC_ALL=C to make sure we'll have "correct" output Signed-off-by: Arnaud Patard <apatard@hupstream.com>
emsi
referenced
this pull request
in hglkrijger/WALinuxAgent
Jun 3, 2016
- correct scvmm references - add unit tests for scvmm detection - ensure all matching devices are mounted and examined for scvmm configuration - exit once vmm startup script is found and executed - fixes Azure#185
hglkrijger
added a commit
to hglkrijger/WALinuxAgent
that referenced
this pull request
Jul 24, 2018
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using dpkg-query -s is more appropriate than using dpkg -l and grep -q.
The only way to have 0 returned by dpkg-query -s is to have NM installed
and dpkg -l |grep -q may return 1 if the package is not yet known in the
base (for instance, right after installing).
Signed-off-by: Arnaud Patard apatard@hupstream.com