-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NM should not be restarted during hostname publish if NM_CONTROLLED=y #3008
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
ae5d01c
Only restart NM if NM_controlled=n
maddieford 5f43efc
Clean up code
maddieford bd82e73
Clean up code
maddieford 4f9b960
improve logging
maddieford 59337cc
Merge branch 'develop' into redhat_hostname_pub
maddieford dbaffa2
Make check on NM_CONTROLLED value sctrict
maddieford 6d46cbd
Merge branch 'redhat_hostname_pub' of github.com:maddieford/WALinuxAg…
maddieford 5a8de53
Merge branch 'develop' into redhat_hostname_pub
maddieford File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is encide_output needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If encode_output is True the stdout is returned as a string, otherwise it is returned as a bytes object.
When True, the result is unicode (u'no'). It was easier to do the comparison if encode_output=False and the result is in bytes