Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix install_requires list syntax #3263

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

maddieford
Copy link
Contributor

@maddieford maddieford commented Nov 25, 2024

Description

This previous change updated the install_requires list in setup.py to use 'package;platform_requirement' syntax: #3070
As pointed out by this SO post, this syntax is only supported by setuptools v36.2+: https://stackoverflow.com/questions/21082091/install-requires-based-on-python-version
As a result, when users run setup.py install with setuptools < 36.2, they are seeing the following error:
error in WALinuxAgent setup command: 'install_requires' must be a string or list of strings containing valid project/version requirement specifiers

This PR reverts the change to use the previous syntax (check python version using sys.version_info and append packages to install_requires accordingly).

This change has been tested manually on CentOS 7.9. Automation will be added to test these changes in a future PR.

Issue #


PR information

  • Ensure development PR is based on the develop branch.
  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made

Quality of Code and Contribution Guidelines

@maddieford maddieford merged commit a6e735e into Azure:hotfix-2.12.0.3 Nov 25, 2024
9 of 11 checks passed
@maddieford maddieford deleted the fix_requires_list branch November 25, 2024 23:21
maddieford added a commit to maddieford/WALinuxAgent that referenced this pull request Nov 26, 2024
maddieford added a commit that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants