Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This previous change updated the install_requires list in setup.py to use 'package;platform_requirement' syntax: #3070
As pointed out by this SO post, this syntax is only supported by setuptools v36.2+: https://stackoverflow.com/questions/21082091/install-requires-based-on-python-version
As a result, when users run
setup.py install
with setuptools < 36.2, they are seeing the following error:error in WALinuxAgent setup command: 'install_requires' must be a string or list of strings containing valid project/version requirement specifiers
This PR reverts the change to use the previous syntax (check python version using sys.version_info and append packages to install_requires accordingly).
This change has been tested manually on CentOS 7.9. Automation will be added to test these changes in a future PR.
Issue #
PR information
develop
branch.Quality of Code and Contribution Guidelines