support shorthand syntax in example generation #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kairu-ms
reviewed
Jan 10, 2024
| @@ -0,0 +1,19 @@ | |||
| def serialize(obj): | |||
There was a problem hiding this comment.
The shorthand syntax should be belong to Command module not Swagger module.
kairu-ms
reviewed
Jan 10, 2024
| @@ -106,7 +106,7 @@ def mapping(self, example_dict): | |||
| val=value | |||
| ) | |||
| if item and item.is_top_level: | |||
| self.example_items.append((item.arg_option, json.dumps(value))) | |||
| self.example_items.append((item.arg_option, serialize(value))) | |||
There was a problem hiding this comment.
The final output serialization no matter to json string or shorthand syntax string, should be implemented in Command module.
kairu-ms
reviewed
Jan 10, 2024
| if any(char in escaped for char in (" ", "null", "??", ":", ",", "{", "}", "[", "]")): | ||
| escaped = "'" + escaped + "'" | ||
|
|
||
| return repr(escaped)[1:-1] # ignore quotes |
There was a problem hiding this comment.
Should replace None by null in shorthand syntax expression
kairu-ms
reviewed
Jan 10, 2024
|
|
||
|
|
||
| def test_with_special_characters(): | ||
| obj = { |
There was a problem hiding this comment.
You can add tests for None value
kairu-ms
reviewed
Jan 11, 2024
kairu-ms
approved these changes
Jan 11, 2024
Co-authored-by: kai ru <69238381+kairu-ms@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.