openshift and agentpool fix

Azure · Oct 4, 2018 · ea07008 · ea07008
1 parent ac70fc0
commit ea07008
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/pkg/acsengine/defaults.go b/pkg/acsengine/defaults.go
@@ -494,7 +494,7 @@ func setMasterProfileDefaults(a *api.Properties, isUpgrade bool) {
 	if a.MasterProfile.Distro == "" {
 		if a.OrchestratorProfile.IsKubernetes() {
 			a.MasterProfile.Distro = api.AKS
-		} else {
+		} else if !a.OrchestratorProfile.IsOpenShift() {
 			a.MasterProfile.Distro = api.Ubuntu
 		}
 	}
@@ -647,14 +647,14 @@ func setAgentProfileDefaults(a *api.Properties, isUpgrade, isScale bool) {
 			profile.AcceleratedNetworkingEnabled = helpers.PointerToBool(!isUpgrade && !isScale && helpers.AcceleratedNetworkingSupported(profile.VMSize))
 		}
 
-		if a.MasterProfile.Distro == "" {
+		if profile.Distro == "" {
 			if a.OrchestratorProfile.IsKubernetes() {
 				if profile.OSDiskSizeGB != 0 && profile.OSDiskSizeGB < api.VHDDiskSizeAKS {
 					profile.Distro = api.Ubuntu
 				} else {
 					profile.Distro = api.AKS
 				}
-			} else {
+			} else if !a.OrchestratorProfile.IsOpenShift() {
 				profile.Distro = api.Ubuntu
 			}
 		}

diff --git a/pkg/acsengine/defaults_test.go b/pkg/acsengine/defaults_test.go
@@ -652,14 +652,14 @@ func TestSetComponentsNetworkDefaults(t *testing.T) {
 		expectedDistro      api.Distro              // expected result default disto to be used
 	}{
 		{
-			"ubuntu_kubernetes",
+			"default_kubernetes",
 			api.OrchestratorProfile{
 				OrchestratorType: api.Kubernetes,
 			},
 			api.AKS,
 		},
 		{
-			"rhel_openshift",
+			"default_openshift",
 			api.OrchestratorProfile{
 				OrchestratorType: api.OpenShift,
 			},