Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Add --feature-gates handling for kubelet and api server #2032

Merged
merged 9 commits into from
Jan 17, 2018
Merged

Add --feature-gates handling for kubelet and api server #2032

merged 9 commits into from
Jan 17, 2018

Commits on Jan 11, 2018

  1. Add --feature-gates handling 

    For kubeletConfig, preserve the existing behaviour of adding Accelerators=true for agent config (for kubernetes 1.6.0 and later)
    @stuartleeks
    stuartleeks committed Jan 11, 2018
    Configuration menu
    Copy the full SHA
    31f5c1b View commit details
    Browse the repository at this point in the history

  2. simplified default implementation and removed KUBELET_FEATURE_GATES

    @jackfrancis
    jackfrancis committed Jan 11, 2018
    Configuration menu
    Copy the full SHA
    1e786ad View commit details
    Browse the repository at this point in the history

  3. unnecessary default assignment, and simple validation

    @jackfrancis
    jackfrancis committed Jan 11, 2018
    Configuration menu
    Copy the full SHA
    ecb8a35 View commit details
    Browse the repository at this point in the history

  4. removed copyMap func

    @jackfrancis
    jackfrancis committed Jan 11, 2018
    Configuration menu
    Copy the full SHA
    3420429 View commit details
    Browse the repository at this point in the history

  5. enforce min version, "Accelerators=true" is only for agents

    @jackfrancis
    jackfrancis committed Jan 11, 2018
    Configuration menu
    Copy the full SHA
    0f590e5 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2018

  1. Pass current version in to addDefaultFeatureGates 

    Generalise addDefaultFeatureGates by passing in current orchestrator version, and deferring the minimum required version to callers
    @stuartleeks
    stuartleeks committed Jan 12, 2018
    Configuration menu
    Copy the full SHA
    ded52cd View commit details
    Browse the repository at this point in the history

  2. Add tests for --feature-gates behaviour 

    Test for only adding Accelerators=true for 1.6.0+
Test for correct application of KubeletConfig from top-level vs Master/AgentProfile
    @stuartleeks
    stuartleeks committed Jan 12, 2018
    Configuration menu
    Copy the full SHA
    afa7541 View commit details
    Browse the repository at this point in the history

  3. Avoid ref sharing for kubeletConfig 

    Fix failing test by avoiding reference sharing of kubeletConfig properites
on master and agent profiles
    @stuartleeks
    stuartleeks committed Jan 12, 2018
    Configuration menu
    Copy the full SHA
    e5f7cd6 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2018

  1. Remove outdated comments

    @stuartleeks
    stuartleeks committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    0ace799 View commit details
    Browse the repository at this point in the history