This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
fix disk unavailable issue when mounting multiple azure disks due to dev name change #2410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dev name change fall back azure file storage class change
JiangtianLi
reviewed
Mar 8, 2018
| @@ -10,6 +10,7 @@ provisioner: kubernetes.io/azure-disk | |||
| parameters: | |||
| kind: Managed | |||
| storageaccounttype: Standard_LRS | |||
| cachingmode: None | |||
There was a problem hiding this comment.
What is the default cachingmode if it is not set?
There was a problem hiding this comment.
default is ReadWrite, and I have set to None in current k8s upstream code from v1.7-v1.10, all minor version should fix this issue.
tesharp
pushed a commit
to tesharp/acs-engine
that referenced
this pull request
Mar 16, 2018
…dev name change (Azure#2410) fall back azure file storage class change
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
fix disk unavailable issue when mounting multiple azure disks due to dev name change
When User mount the 6th azure data disk on an D2_V2 VM, other azure disk would be unavailable due to device name change. This PR set the default
cachingmodeasNoneto fix this issue.You could find more details in this upstream PR: kubernetes/kubernetes#60346
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #1918Special notes for your reviewer:
@jackfrancis @JiangtianLi This is a critical bug fix, we have changed the default
cachingmodevalue asNonein upstream code, while as a simple workaround, we could change thecachingmodevalue toNonein azure disk storage class. Could you fix it in AKS also? Thanks.Release note: